Make PST GPU-compatible #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
==========================================
+ Coverage 70.53% 70.74% +0.21%
==========================================
Files 96 106 +10
Lines 5976 6710 +734
==========================================
+ Hits 4215 4747 +532
- Misses 1761 1963 +202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Aligns particle shifting and velocity extraction routines to be GPU-compatible by introducing specialized dispatch and buffer handling.
- Adds
current_velocityoverloads for GPU-friendly extraction based on density calculators. - Refactors
particle_shifting!to use a combined temp cache and replaces CPU-based max-velocity computation with a GPU-compatible approach. - Adjusts the literal for
Rto a rational form.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/schemes/fluid/weakly_compressible_sph/system.jl | Added current_velocity methods for SummationDensity and ContinuityDensity |
| src/callbacks/particle_shifting.jl | Renamed temp cache to vu_cache, replaced eachparticle max with reinterpret approach, and changed R literal |
Comments suppressed due to low confidence (2)
src/schemes/fluid/weakly_compressible_sph/system.jl:254
- [nitpick] Consider adding unit tests for both
SummationDensityandContinuityDensitycases ofcurrent_velocityto verify GPU-compatible behavior under different density calculators.
@inline function current_velocity(v, ::SummationDensity,
src/callbacks/particle_shifting.jl:68
SVectoris used here but not imported in this file; addusing StaticArrays: SVectorat the top to prevent an undefined constant error.
reinterpret(reshape, SVector{ndims(system), eltype(v)},
LasNikas
reviewed
May 22, 2025
svchb
approved these changes
May 22, 2025
LasNikas
approved these changes
May 23, 2025
|
\run-gpu-tests |
|
/run-gpu-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @LasNikas.